fix: handle skipped questions in when with display option #1853

Sakthieswaran-tech · 2025-10-18T09:24:08Z

Display questions when when returns { ask: false, display: true } without adding to answers.
Fully skip questions when when returns { ask: false, display: false } or false.
Added tests to cover these cases.

codecov · 2025-10-18T09:25:01Z

Codecov Report

❌ Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@31fc3ad). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
packages/inquirer/src/ui/skipped-renderer.ts	96.42%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1853   +/-   ##
=======================================
  Coverage        ?   95.72%           
=======================================
  Files           ?       46           
  Lines           ?     2876           
  Branches        ?      768           
=======================================
  Hits            ?     2753           
  Misses          ?      114           
  Partials        ?        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sakthieswaran-tech · 2025-10-21T17:53:33Z

Hey @SBoudrias , I’ve added more test cases and all checks are passing. Could you take a look when you get a chance and let me know if anything needs changes?

SBoudrias

The PR is a little big, so I didn't review all of it in depth yet. Here's a few early thoughts to streamline the code a little.

SBoudrias · 2025-10-25T20:46:01Z

packages/inquirer/src/ui/skipped-renderer.ts

+  confirm: (question: TypedQuestion) => {
+    const defaultVal = question.default;
+    const answerText = defaultVal === true ? 'Yes' : defaultVal === false ? 'No' : '';
+    const prefix = '?';


This must be taken from the theme

SBoudrias · 2025-10-25T20:46:13Z

packages/inquirer/src/ui/skipped-renderer.ts

+    const answerText = defaultVal === true ? 'Yes' : defaultVal === false ? 'No' : '';
+    const prefix = '?';
+    const line = `${prefix} ${question.message} ${answerText}`;
+    return colors.dim(line);


This should also be based on the theme.

Updated to use the makeTheme() method for getting the prefix instead of hardcoding '?', and replaced dim with style.help

SBoudrias · 2025-10-25T20:46:44Z

packages/inquirer/package.json

    "run-async": "^4.0.5",
-    "rxjs": "^7.8.2"
+    "rxjs": "^7.8.2",
+    "yoctocolors-cjs": "^2.1.3"


Let's match the version from other packages in the workspace.

SBoudrias · 2025-10-25T20:47:05Z

README.md

@@ -1 +1 @@
-packages/prompts/README.md
+packages/prompts/README.md


git checkout main -- README.md to undo this change.

SBoudrias · 2025-10-25T20:49:29Z

packages/inquirer/src/ui/prompt.ts

+        return { display, ask };
+      }
      return Boolean(shouldRun);


Let's normalize the return types so it's always consistent.

Normalized the function to return {display, ask}.

SBoudrias · 2025-10-25T20:50:27Z

packages/inquirer/src/ui/prompt.ts

+                if (ask || display) {
+                  return of({ question, ask });
+                }
+                return EMPTY;


It's a little weird to read the code where we handle the skip here, and the rendering in the next event. Let's combine that logic in a single place.

Sakthieswaran-tech · 2025-10-28T08:12:28Z

Rebased with latest main.
Incorporated all the review changes (including normalization and theme updates).
The reviewed fixes are now part of the existing commits after rebase.

Sakthieswaran-tech force-pushed the feature/display-skipped-questions branch 2 times, most recently from fe5866b to 7f04251 Compare October 18, 2025 11:41

SBoudrias reviewed Oct 25, 2025

View reviewed changes

Sakthieswaran-tech force-pushed the feature/display-skipped-questions branch from 3ecbfcd to 8e76e3c Compare October 27, 2025 16:25

Sakthieswaran-tech added 2 commits October 27, 2025 22:51

fix: handle skipped questions in when with display option

a97a797

test cases added for all prompts

5b30e81

Sakthieswaran-tech force-pushed the feature/display-skipped-questions branch from 8e76e3c to 5b30e81 Compare October 28, 2025 08:09

		@@ -1 +1 @@
		packages/prompts/README.md
		packages/prompts/README.md

Uh oh!

Uh oh!

fix: handle skipped questions in when with display option #1853

Are you sure you want to change the base?

fix: handle skipped questions in when with display option #1853

Uh oh!

Conversation

Sakthieswaran-tech commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Sakthieswaran-tech commented Oct 21, 2025

Uh oh!

SBoudrias left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sakthieswaran-tech commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Sakthieswaran-tech commented Oct 18, 2025 •

edited

Loading

codecov bot commented Oct 18, 2025 •

edited

Loading