Breaking: Next major Inquirer version #1854
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBoudrias
force-pushed
the
next-major
branch
2 times, most recently
from
3a8af47 to
999c4a6
Compare
LitoMore
reviewed
Oct 22, 2025
SBoudrias
force-pushed
the
next-major
branch
2 times, most recently
from
9841826 to
3d858c7
Compare
LitoMore
requested changes
Oct 25, 2025
| "packageManager": "yarn@4.9.4+sha512.7b1cb0b62abba6a537b3a2ce00811a843bea02bcf53138581a6ae5b1bf563f734872bd47de49ce32a9ca9dcaff995aa789577ffb16811da7c603dcf69e73750b", | ||
| "engines": { | ||
| "node": ">=18" | ||
| "node": ">=23 ^22.13.0 ^21.7.0 ^20.12.0" |
There was a problem hiding this comment.
Incorrect format. Here shoule be:
Suggested change
| "node": ">=23 ^22.13.0 ^21.7.0 ^20.12.0" | |
| "node": ">=23 || ^22.13.0 || ^21.7.0 || ^20.12.0" |
There was a problem hiding this comment.
Do you have a source for that?
The current format parsed properly, and I see that same format over here: https://docs.npmjs.com/cli/v11/configuring-npm/package-json#engines
There was a problem hiding this comment.
It looks like the space between versions means and.
Here we should use or. You can reverse them and try again:
# Run this below with Node.js 23 or later
^20.12 ^20.7 >=23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root PR to collect all breaking changes I intend to rollout with our next major version.
TODOs
attw(to be confirmed: I think it's fine and doesn't bring value anymore)yoctocolorswith built-instyleText([Breaking - Node 20] Replace yoctocolors-cjs with styleText #1850)@deprecatedacross the codebase.packages/core/src/lib/promise-polyfill.tsAnything else I'm missing?
Note about dependency substitutions
I'm very aligned with the efforts within the Node.js community to cut down on transitive dependency size.
That being said, I'm only open to considering alternatives from known and reputable maintainers. Inquirer is a very popular and trusted package. I do not to risk putting the project in the path of a supply chain of attack.
I'll look at PRs the community sends, but you might want to open a ticket first for us to discuss the alternative package you recommend. I'm also very open to rehoming some smaller packages under the Inquirer project and assume future ownership (like we did with external-editor, or
@inquirer/figures).