Remove Typescript 3rd party helpers #1856
Open
+562
−1,205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBoudrias
force-pushed
the
chore/bye-tshy
branch
3 times, most recently
from
f5c398b to
b9f14c4
Compare
SBoudrias
force-pushed
the
next-major
branch
3 times, most recently
from
3d858c7 to
71c9cb1
Compare
SBoudrias
force-pushed
the
chore/bye-tshy
branch
3 times, most recently
from
98172bd to
d972f45
Compare
SBoudrias
commented
Oct 26, 2025
SBoudrias
commented
Oct 26, 2025
Remove tshy references from: - .gitignore (tshy directories and build files) - .prettierignore (tshy directory) - turbo.json (tshy input pattern) Also updates yarn cache after dependency changes.
SBoudrias
force-pushed
the
chore/bye-tshy
branch
from
d972f45 to
7d33338
Compare
SBoudrias
commented
Oct 28, 2025
Changes: - Fixed TypeScript errors by removing examples from root tsconfig - Re-added isolatedDeclarations to ansi, external-editor, figures, and type packages - Updated tools/setup-packages.ts to handle all workspace packages (internals/) - Added bin field handling in publishConfig for packages with CLI binaries - Fixed TypeScript type errors in tools/setup-packages.ts - Re-added .tshy to .gitignore as legacy build artifacts Addresses PR #1856 review comments.
- Don't set author, license, repository, keywords, homepage for private packages - Don't set publishConfig for private packages - Updated tools/setup-packages.ts to check private flag and conditionally set/remove fields
SBoudrias
commented
Oct 28, 2025
SBoudrias
commented
Oct 28, 2025
Remove @arethetypeswrong/cli dependency and attw scripts from all packages as they're no longer needed with the tshy removal. Create separate tsconfig for examples directory to enable ESLint parsing without TypeScript compilation errors (examples depend on built package, not source files).
The previous commit re-added examples to the root tsconfig.json which caused TypeScript compilation errors. Examples should use their own separate tsconfig files and not be checked by the root compilation. Changes: - Remove **/examples/**/* from root tsconfig.json include array - Add tsconfig.json for packages/external-editor/examples/ - This allows ESLint to parse example files without TypeScript errors The examples remain as-is with their 'as const' type assertions.
SBoudrias
commented
Oct 29, 2025
| pkg.scripts = pkg.scripts ?? {}; | ||
| pkg.scripts['tsc'] = 'tshy'; | ||
| pkg.scripts ??= {}; | ||
| pkg.scripts['tsc'] = 'tsc -p tsconfig.json'; |
There was a problem hiding this comment.
We'll also need here to think about adding chmod +x <bin> after the compilation when there's bin defined in the package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.